unknowntpo commented on code in PR #5905:
URL: https://github.com/apache/gravitino/pull/5905#discussion_r1993253020


##########
clients/filesystem-fuse/src/main.rs:
##########
@@ -193,6 +213,33 @@ fn main() -> Result<(), i32> {
                 path.to_string_lossy().to_string()
             };
 
+            if env::var("RUST_LOG").is_ok() {
+                init_tracing_subscriber(LevelFilter::INFO, "");
+            } else {
+                // if debug > 0, it means that we needs fuse_debug.
+                app_config.fuse.fuse_debug = debug > 0 || 
app_config.fuse.fuse_debug;
+                match debug {
+                    0 => {
+                        init_tracing_subscriber(LevelFilter::INFO, "");

Review Comment:
   Okay, so I think the spec will be:
   
   - When `debug == 0`, we use value of RUST_LOG as directives, the actual 
effect should be RUST_LOG="<original_rust_log_value>".
   - When `debug != 0`, we particularly we need to append `gvfs_fuse=debug` to 
the value of `RUST_LOG`, the actual effect should be 
`RUST_LOG="<original_rust_log_value>,gvfs_fuse=debug"`, this ensures that 
whatever the `RUST_LOG` is, `gvfs_fuse` still has debug level logging.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to