unknowntpo commented on code in PR #5905:
URL: https://github.com/apache/gravitino/pull/5905#discussion_r1992580883
##########
clients/filesystem-fuse/src/main.rs:
##########
@@ -193,6 +213,33 @@ fn main() -> Result<(), i32> {
path.to_string_lossy().to_string()
};
+ if env::var("RUST_LOG").is_ok() {
+ init_tracing_subscriber(LevelFilter::INFO, "");
+ } else {
+ // if debug > 0, it means that we needs fuse_debug.
+ app_config.fuse.fuse_debug = debug > 0 ||
app_config.fuse.fuse_debug;
+ match debug {
+ 0 => {
+ init_tracing_subscriber(LevelFilter::INFO, "");
Review Comment:
I ask this because at here,
> 2. When the parameter debug != 0:
• If RUST_LOG is set, use its value and append
gvfs_fuse::fuse_api_handle_debug=debug without overriding RUST_LOG.
you use the words `gvfs_fuse::fuse_api_handle_debug=debug`.
but at here,
> My point is that if the user sets RUST_LOG='info' and debug=1, the log
level is equivalent to RUST_LOG="info, gvfs_fuse=debug".
you use the word `gvfs_fuse=debug`
you say `gvfs_fuse=debug`, does it mean the whole `gvfs_fuse` or just an
abbreviation of `gvfs_fuse::fuse_api_handle_debug` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
