jerqi commented on code in PR #6575:
URL: https://github.com/apache/gravitino/pull/6575#discussion_r1978705115
##########
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationPlugin.java:
##########
@@ -745,6 +763,110 @@ public Boolean onGroupAcquired(Group group) {
return Boolean.TRUE;
}
+ @Override
+ public void close() throws IOException {
+ if (!isCreatedByPlugin) {
+ return;
+ }
+
+ try {
+ rangerClient.deleteService(rangerServiceName);
+ } catch (RangerServiceException rse) {
+ throw new AuthorizationPluginException(
+ "Fail to delete Ranger service %s, exception: %s",
rangerServiceName, rse.getMessage());
+ }
Review Comment:
No. It's not only used by UT.
If we have a Ranger server and Ranger HDFS or Hive services are not
pre-created , we need the to create the by our Gravitino.
If these Ranger Hive services or HDFS services are created by Gravitino,
Gravitino should delete them, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
