tengqm commented on code in PR #6575:
URL: https://github.com/apache/gravitino/pull/6575#discussion_r1977589211
##########
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationPlugin.java:
##########
@@ -745,6 +763,108 @@ public Boolean onGroupAcquired(Group group) {
return Boolean.TRUE;
}
+ @Override
+ public void close() throws IOException {
+ try {
+ if (isCreatedByPlugin) {
+ rangerClient.deleteService(rangerServiceName);
+ }
+ } catch (RangerServiceException rse) {
+ throw new AuthorizationPluginException(
+ "Fail to delete Ranger service %s, exception: %s",
rangerServiceName, rse.getMessage());
+ }
Review Comment:
```suggestion
if (!isCreatedByPlugin)
return;
try {
rangerClient.deleteService(rangerServiceName);
} catch (RangerServiceException rse) {
throw new AuthorizationPluginException(
"Fail to delete Ranger service %s, exception: %s",
rangerServiceName, rse.getMessage());
}
```
##########
core/src/main/java/org/apache/gravitino/connector/authorization/BaseAuthorization.java:
##########
@@ -45,6 +45,9 @@
public abstract class BaseAuthorization<T extends BaseAuthorization>
implements AuthorizationProvider, Closeable {
+ /** UUID represents */
Review Comment:
?
##########
core/src/main/java/org/apache/gravitino/hook/CatalogHookDispatcher.java:
##########
@@ -131,18 +131,18 @@ public boolean dropCatalog(NameIdentifier ident, boolean
force)
return false;
}
- // If we call the authorization plugin after dropping catalog, we can't
load the plugin of the
- // catalog
Catalog catalog = dispatcher.loadCatalog(ident);
- boolean dropped = dispatcher.dropCatalog(ident, force);
- if (dropped && catalog != null) {
+ if (catalog != null) {
List<String> locations =
AuthorizationUtils.getMetadataObjectLocation(ident,
Entity.EntityType.CATALOG);
AuthorizationUtils.removeCatalogPrivileges(catalog, locations);
}
- return dropped;
+ // We should call the authorization plugin before dropping the catalog,
because the dropping
+ // catalog
+ // will close the authorization plugin.
Review Comment:
?
##########
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationPlugin.java:
##########
@@ -91,9 +94,42 @@ protected RangerAuthorizationPlugin(String metalake,
Map<String, String> config)
rangerAdminName =
config.get(RangerAuthorizationProperties.RANGER_USERNAME);
// Apache Ranger Password should be minimum 8 characters with min one
alphabet and one numeric.
String password =
config.get(RangerAuthorizationProperties.RANGER_PASSWORD);
- rangerServiceName =
config.get(RangerAuthorizationProperties.RANGER_SERVICE_NAME);
+
+ String serviceName =
config.get(RangerAuthorizationProperties.RANGER_SERVICE_NAME);
rangerClient = new RangerClientExtension(rangerUrl, authType,
rangerAdminName, password);
+ if (Boolean.parseBoolean(
+
config.get(RangerAuthorizationProperties.RANGER_SERVICE_CREATE_IF_ABSENT))) {
Review Comment:
Please make sure there won't be uncaught exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
