tengqm commented on PR #6542: URL: https://github.com/apache/gravitino/pull/6542#issuecomment-2689784321
> > @tsungchih Thank you for your contributions. :-) > > hi @tengqm > > > The reason I asked this question is that I am (still) wondering whether we can write the code in a more Python way. > > > > > > I've thought about this as well, and I think we should code the Python client the same way as Python, but we want to keep the interface functions of the Python client consistent with the JAVA client. > > In doing so, I'll have to keep the interface `Column` consistent with the Java client that encapsulates the data members as private and exposes getter methods to access them. This goes to the implementation in the PR. I'm confused here. Which strategy for implementing Python client do we have? One way of reasoning this is that we consider the use cases. Does the interface consistency matter for the users of `client-python`? Who are the users of this library? What do they care most, the APIs and utility functions or the implementation structure? There will never be a deterministic answer to this question. It all depends on the use cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
