tengqm commented on PR #6542: URL: https://github.com/apache/gravitino/pull/6542#issuecomment-2689392452
Yes. There are two extremes here. Either you are auto-generating the Python code from Java, you only care about the correctness of the generator, you don't care if the code is complicated because they will be overwritten next time when you run the generator. Or you may want to focus on producing usable, useful, working and MAINTAINABLE code with the least lines of code. One rule of thumb for me is that it is always easy to add something to an existing code base, but it is never so easy to get rid of them once they are merged. My overall suggestion is to drastically simplify the code without sacrificing the its functionality. It helps save our lives for something else more interesting/challenging. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
