justinmclean commented on code in PR #6538:
URL: https://github.com/apache/gravitino/pull/6538#discussion_r1971207203
##########
clients/cli/src/main/java/org/apache/gravitino/cli/outputs/PlainFormat.java:
##########
@@ -231,4 +234,43 @@ public String getOutput(Audit audit) {
audit.lastModifiedTime() == null ? "N/A" : audit.lastModifiedTime());
}
}
+
+ /**
+ * Formats an array of {@link org.apache.gravitino.rel.Column} into a
six-column table display.
+ * Lists all column names, types, default values, auto-increment, nullable,
and comments in a
+ * plain format.
+ */
+ static final class ColumnListPlainFormat extends PlainFormat<Column[]> {
+
+ /**
+ * Creates a new {@link ColumnListPlainFormat} with the specified output
properties.
+ *
+ * @param context The command context.
+ */
+ public ColumnListPlainFormat(CommandContext context) {
+ super(context);
+ }
+
+ /** {@inheritDoc} */
+ @Override
+ public String getOutput(Column[] columns) {
+ String header =
+ COMMA_JOINER.join(
+ "name", "datatype", "default_value", "comment", "nullable",
"auto_increment");
Review Comment:
I'd also go with empty values rather than "N/A" for columns with no default
values. The suggestion regarding autoincrement is also a good one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
