tengqm commented on code in PR #6538:
URL: https://github.com/apache/gravitino/pull/6538#discussion_r1971132108
##########
clients/cli/src/main/java/org/apache/gravitino/cli/outputs/PlainFormat.java:
##########
@@ -231,4 +234,43 @@ public String getOutput(Audit audit) {
audit.lastModifiedTime() == null ? "N/A" : audit.lastModifiedTime());
}
}
+
+ /**
+ * Formats an array of {@link org.apache.gravitino.rel.Column} into a
six-column table display.
+ * Lists all column names, types, default values, auto-increment, nullable,
and comments in a
+ * plain format.
+ */
+ static final class ColumnListPlainFormat extends PlainFormat<Column[]> {
+
+ /**
+ * Creates a new {@link ColumnListPlainFormat} with the specified output
properties.
+ *
+ * @param context The command context.
+ */
+ public ColumnListPlainFormat(CommandContext context) {
+ super(context);
+ }
+
+ /** {@inheritDoc} */
+ @Override
+ public String getOutput(Column[] columns) {
+ String header =
+ COMMA_JOINER.join(
+ "name", "datatype", "default_value", "comment", "nullable",
"auto_increment");
Review Comment:
"auto increment" only applies to an integer column,
how about print a field's data type as `integer (autoinc)`, rather than
making `AutoIncrement` a column for all fields?
##########
clients/cli/src/main/java/org/apache/gravitino/cli/outputs/LineUtil.java:
##########
@@ -100,4 +104,27 @@ public static String capitalize(String str) {
}
}
}
+
+ /**
+ * Get the default value of a column.
+ *
+ * @param defaultValue the default value expression.
+ * @return the default value as a string.
+ */
+ public static String getDefaultValue(Expression defaultValue) {
+ if (defaultValue == null
+ || defaultValue ==
org.apache.gravitino.rel.Column.DEFAULT_VALUE_NOT_SET) {
+ return "N/A";
+ }
+
+ if (defaultValue instanceof Literal && ((Literal<?>) defaultValue).value()
!= null) {
+ return ((Literal<?>) defaultValue).value().toString();
+ } else if (defaultValue instanceof FunctionExpression) {
+ return defaultValue.toString();
+ } else if (defaultValue.references().length == 0) {
+ return "N/A";
+ }
Review Comment:
How about simply leaving the columns with no default values as empty?
Too many `N/A`s makes the table very busy.
At the same time, for a string (e.g. `varchar`) column, explicitly state
that the default value is `""` if so. Empty strings are different from null
ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
