FANNG1 commented on code in PR #5998:
URL: https://github.com/apache/gravitino/pull/5998#discussion_r1967253661
##########
core/src/main/java/org/apache/gravitino/listener/TagEventDispatcher.java:
##########
@@ -152,8 +186,11 @@ public MetadataObject[] listMetadataObjectsForTag(String
metalake, String name)
public String[] listTagsForMetadataObject(String metalake, MetadataObject
metadataObject) {
// TODO: listTagsForMetadataObjectPreEvent
try {
- // TODO: listTagsForMetadataObjectEvent
- return dispatcher.listTagsForMetadataObject(metalake, metadataObject);
+ String[] tags = dispatcher.listTagsForMetadataObject(metalake,
metadataObject);
+ eventBus.dispatchEvent(
Review Comment:
After another though, seems we could didn't pass the specific tag or
metadata objects for LIST events to keep consistent with other LIST events like
`ListTableEvent` or `ListFilesetEvent`, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
