justinmclean commented on PR #6327: URL: https://github.com/apache/gravitino/pull/6327#issuecomment-2606212278
First off, I would split this into two PRs one for the "config" and one for the output if possible. There are a few variable names that need improvement, but overall I think this is overly complex. There is no real need for xxxConfig classed right now, you have also moved too much into them e.g metalake each class should have a single responsibility and only contain related data. As suggested I think at this point a command context would be a better way to go, along with a thin wrapper around the output calls. Take a look at https://github.com/apache/gravitino/pull/6343 and see what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
