Abyss-lord commented on PR #6327: URL: https://github.com/apache/gravitino/pull/6327#issuecomment-2603887095
> Hi @Abyss-lord, thanks for the PR, while I feel this change is a little bit heavy, which may make the CLI code harder to maintain. Regarding the feature, would you add more information in the issue description, so that we can understand the scenario? Thank you! @shaofengshi As the CLI continues to evolve, we face growing challenges with code maintainability. There are two main issues we need to address: 1. Parameter Management Challenge:Currently, commands require numerous individual arguments. Adding a new option requires modifications across all commands.This approach doesn't scale well as we add more functionality 2. Inconsistent Output Handling:Output methods are fragmented between `System.out/err` and `OutputFormat#output` and Lack of standardized output handling makes the interface inconsistent To address these issues, I propose the following solutions: For the first question, I propose grouping related options into logical parameter clusters according to action not entity. This approach will improve code organization and maintainability. The proposed structure is illustrated in the following class diagram...  When the refactoring is complete the command just needs to pass the **configuration** + **FullName**, e.g. `newDeleteTable(url, ignore, force, metalake, catalog, schema, table)` -> `newDeleteTable(DeleteConfig config, FullName fullname)` For the second problem, I've redesigned the OutputFormat interface to improve extensibility. I refactor the `OutputFormat` to increase its extensibility, but also leave room for extension, such as `sorting`, `limit` and other functions.  Now all of the CLI's information can be displayed using a single output method.  Although this is a lot of code changes, IMHO I think it will be a big benefit for future client development. design doc: https://docs.google.com/document/d/1JU20XPHBMb-boOhdNmeZC9acyYupuj7EvQKfc1JaJBo/edit?usp=sharing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
