tengqm commented on code in PR #5977:
URL: https://github.com/apache/gravitino/pull/5977#discussion_r1911870664
##########
bin/common.sh:
##########
@@ -42,6 +42,15 @@ if [[ -f "${GRAVITINO_CONF_DIR}/gravitino-env.sh" ]]; then
. "${GRAVITINO_CONF_DIR}/gravitino-env.sh"
fi
+if [[ -z "${GRAVITINO_VERSION}" ]]; then
+ echo -e "No variable GRAVITINO_VERSION was found, you may need to:\n" \
+ "1. Ensure that a compiled version of Gravitino is available at" \
+ "<path-to-gravitino>/distribution/package. If not, you must compile it
first.\n" \
Review Comment:
```suggestion
"\${GRAVITINO_HOME}/distribution/package. You may need to compile it first
" \
"if you are installing the software from source code.\n" \
```
##########
docs/getting-started.md:
##########
@@ -176,7 +176,7 @@ To use Gravitino locally on macOS or Linux, follow these
similar steps:
Or, you can install Gravitino from scratch, follow
[how-to-build](./how-to-build.md) and [how-to-install](./how-to-install.md).
-3. Start Gravitino using the gravitino.sh script:
+3. Start Gravitino using the gravitino.sh script in the binary release package
or Docker image:
```shell
<path-to-gravitino>/bin/gravitino.sh start
Review Comment:
`path-to-gravitino` is not a professional way to communicate to users.
We can mimic the Java way of running commands. That is, we need a
`GRAVITINO_HOME`
environment variable to run the commands/scripts.
##########
bin/common.sh:
##########
@@ -42,6 +42,15 @@ if [[ -f "${GRAVITINO_CONF_DIR}/gravitino-env.sh" ]]; then
. "${GRAVITINO_CONF_DIR}/gravitino-env.sh"
fi
+if [[ -z "${GRAVITINO_VERSION}" ]]; then
+ echo -e "No variable GRAVITINO_VERSION was found, you may need to:\n" \
+ "1. Ensure that a compiled version of Gravitino is available at" \
+ "<path-to-gravitino>/distribution/package. If not, you must compile it
first.\n" \
+ "2. Execute gravitino.sh from <path-to-gravitino>/distribution/package/bin" \
Review Comment:
```suggestion
"2. Execute gravitino.sh in the
\${GRAVITINO_HOME}/distribution/package/bin directory."
```
##########
bin/common.sh:
##########
@@ -42,6 +42,15 @@ if [[ -f "${GRAVITINO_CONF_DIR}/gravitino-env.sh" ]]; then
. "${GRAVITINO_CONF_DIR}/gravitino-env.sh"
fi
+if [[ -z "${GRAVITINO_VERSION}" ]]; then
+ echo -e "No variable GRAVITINO_VERSION was found, you may need to:\n" \
Review Comment:
```suggestion
echo -e "GRAVITINO_VERSION is not set, you may need to:\n" \
```
##########
bin/common.sh:
##########
@@ -42,6 +42,15 @@ if [[ -f "${GRAVITINO_CONF_DIR}/gravitino-env.sh" ]]; then
. "${GRAVITINO_CONF_DIR}/gravitino-env.sh"
fi
+if [[ -z "${GRAVITINO_VERSION}" ]]; then
+ echo -e "No variable GRAVITINO_VERSION was found, you may need to:\n" \
+ "1. Ensure that a compiled version of Gravitino is available at" \
+ "<path-to-gravitino>/distribution/package. If not, you must compile it
first.\n" \
+ "2. Execute gravitino.sh from <path-to-gravitino>/distribution/package/bin" \
+ "and avoid running scripts from other directories."
Review Comment:
Not sure why we want to mention this.
If the scripts cannot be executed from other directory, we need to improve
the them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
