jerqi commented on code in PR #6057:
URL: https://github.com/apache/gravitino/pull/6057#discussion_r1900826752


##########
api/src/test/java/org/apache/gravitino/TestMetadataObjects.java:
##########
@@ -84,4 +84,17 @@ public void testColumnObject() {
             MetadataObjects.of(
                 Lists.newArrayList("catalog", "schema", "table"), 
MetadataObject.Type.COLUMN));
   }
+
+  @Test
+  public void testRoleObject() {
+    // Test legal name
+    MetadataObject roleObject =
+        MetadataObjects.of(Lists.newArrayList("role"), 
MetadataObject.Type.ROLE);
+    Assertions.assertEquals("role", roleObject.fullName());
+
+    // Test illegal name
+    Assertions.assertThrows(

Review Comment:
   You should create the role metadata object by
   ```
   MetadataObjects.of(null, "role.test", ROLE);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to