tengqm commented on code in PR #5943:
URL: https://github.com/apache/gravitino/pull/5943#discussion_r1895109555
##########
clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java:
##########
@@ -29,6 +29,8 @@ public class FullName {
private final CommandLine line;
private String metalakeEnv;
private boolean matalakeSet = false;
+ private boolean isMissingNameInfoVisible = true;
+ private boolean isMalformedInfoVisible = true;
Review Comment:
- This smells like an over engineering case. I don't see a solid reason why
we want to suppress the error messages.
- Even if we really want to show users that the name is missing or invalid,
the flags here are not about whether the messages are "visible" or not. Calling
them "visible" is confusing.
- In addition to showing error messages, we'd better let the CLI user know
how to fix it. For example, we may want to print "a valid name can contain a-z,
A-Z and '.' and '-'." rather than letting them guess what has been wrong. An
error message can be more useful than it is now.
-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
