Abyss-lord commented on PR #5836: URL: https://github.com/apache/gravitino/pull/5836#issuecomment-2540329888
> Sorry, but I would not do it this way, as it adds too much unneeded and duplicated code. > > Taking one example that contains: return CommandUtil.allNotNull(metalake, group); > > a) there is not need to check metalake as that is already checked b) there is no need to check group as it cannot be null @justinmclean Maybe The create command should check metalake, in that way, we can fix #5825 My approach is to add a parameter check and output(maybe in one method) method at the Command level, and prevent the `handle` method from executing if the parameter validation fails.In this case, a logical check will added to the `handle` method to ensure proper execution flow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
