Abyss-lord commented on code in PR #5836:
URL: https://github.com/apache/gravitino/pull/5836#discussion_r1881308076
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTables.java:
##########
@@ -48,6 +49,10 @@ public ListTables(
/** List the names of all tables in a schema. */
@Override
public void handle() {
+ if (metalake == null || catalog == null || schema == null) {
+ showUnSpecifiedMessage();
+ return;
+ }
Review Comment:
> It might be better to add a method to the command base class and call
that, as it is likely several commands need this? Just something to consider.
hi Justin, I noticed that the metalake parameter is almost never empty, it
is given the information during the parsing phase, so do I need to check this
parameter in the `handle` method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
