orenccl commented on code in PR #5643: URL: https://github.com/apache/gravitino/pull/5643#discussion_r1853179216
########## web/web/src/lib/utils/initial.js: ########## @@ -570,10 +566,64 @@ const relationalColumnTypeMap = { ] } -export const getRelationalColumnTypeMap = catalog => { +export const getRelationalColumnType = catalog => { if (Object.keys(relationalColumnTypeMap).includes(catalog)) { return relationalColumnTypeMap[catalog] } return [] } + +const relationalTablePropInfoMap = { + 'lakehouse-iceberg': { + reserved: ['location'], + allowDelete: true, + allowAdd: true + }, + hive: { + reserved: ['comment', 'numFiles', 'totalSize', 'EXTERNAL', 'transient_lastDdlTime'], + allowDelete: true, + allowAdd: true + }, + 'jdbc-mysql': { + reserved: [], + allowDelete: false, + allowAdd: true + }, + 'jdbc-postgresql': { + reserved: [], + allowDelete: false, + allowAdd: false + }, + 'jdbc-doris': { + reserved: [], + allowDelete: true, + allowAdd: true + }, + 'lakehouse-paimon': { + reserved: [ + 'comment', + 'owner', + 'bucket-key', + 'merge-engine', + 'sequence.field', + 'rowkind.field', + 'primary-key', + 'partition' + ], + allowDelete: true, + allowAdd: true + } +} + +export const getRelationalTablePropInfo = catalog => { + if (Object.keys(relationalTablePropInfoMap).includes(catalog)) { Review Comment: This is a better approach and has already been updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org