shaofengshi commented on code in PR #5293:
URL: https://github.com/apache/gravitino/pull/5293#discussion_r1839359443
##########
docs/cli.md:
##########
@@ -503,3 +503,24 @@ gcli tag update --tag tagA --rename newTag
```bash
gcli tag update --tag tagA --comment "new comment"
```
+
+### Owners commands
+
+#### List an owner
+
+```bash
+gcli catalog details --name postgres --owner
+```
+
+#### Set an owner to a user
+
+```bash
+gcli catalog update --name postgres --user admin --owner
Review Comment:
“The user would expect remove to work, it would not be supported as there is
no API to remove an owner”
-- this can (and should) be implemented later, as such action should be
undo-able.
"We may need to add two options rather than one --owner-user and
--owner-group"
-- this is not a key factor I think. the main consideration is using
"update" or "set" command here. "update" is used for updating the major
properties for an entity like comment which usually were set at the creation
time; the "set" command is using for setting additional properties like tag,
owner, which be set after the creation. From the name "SetOwner" we can set a
"set" is a better command name.
Let's think about it, this PR is independent, not that urgent to merge I
think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
