justinmclean commented on code in PR #5293: URL: https://github.com/apache/gravitino/pull/5293#discussion_r1838849165
########## docs/cli.md: ########## @@ -503,3 +503,24 @@ gcli tag update --tag tagA --rename newTag ```bash gcli tag update --tag tagA --comment "new comment" ``` + +### Owners commands + +#### List an owner + +```bash +gcli catalog details --name postgres --owner +``` + +#### Set an owner to a user + +```bash +gcli catalog update --name postgres --user admin --owner Review Comment: If we used the `set` action, that would result in duplicating of code as each handle command method would need to deal with it. It would also mean that the `--owner` flag would have an optional argument, unlike every other flag, which is potentially confusing to the user. I selected this way as it results in less more modular code, the `--owner` is a simple flag, and the approach is less confusing to the user. Another approach could use the `set` command, but that has I feel more issues than this approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
