mchades commented on code in PR #5013:
URL: https://github.com/apache/gravitino/pull/5013#discussion_r1776471055
##########
catalogs/catalog-jdbc-oceanbase/src/main/java/org/apache/gravitino/catalog/oceanbase/operation/OceanBaseDatabaseOperations.java:
##########
@@ -45,17 +55,62 @@ private static Set<String>
createSysOceanBaseDatabaseNames() {
public String generateCreateDatabaseSql(
String databaseName, String comment, Map<String, String> properties) {
- throw new UnsupportedOperationException("Not implemented yet.");
+ String originComment = StringIdentifier.removeIdFromComment(comment);
Review Comment:
FYI:
```java
@Override
public void create(String databaseName, String comment, Map<String,
String> properties)
throws SchemaAlreadyExistsException {
LOG.info("Beginning to create database {}", databaseName);
String originComment = StringIdentifier.removeIdFromComment(comment);
if (!supportSchemaComment() && StringUtils.isNotEmpty(originComment)) {
throw new UnsupportedOperationException(
"Doesn't support setting schema comment: " + originComment);
}
try (final Connection connection = getConnection()) {
JdbcConnectorUtils.executeUpdate(
connection, generateCreateDatabaseSql(databaseName, comment,
properties));
LOG.info("Finished creating database {}", databaseName);
} catch (final SQLException se) {
throw this.exceptionMapper.toGravitinoException(se);
}
}
```
then move the implementation of method `generateCreateDatabaseSql(
String databaseName, String comment, Map<String, String> properties)`
in Mysql to the default implementation.
> Do I need to open a new PR for it?
yeah, make changes in this PR so we can see the impact immediately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
