mchades commented on code in PR #5013:
URL: https://github.com/apache/gravitino/pull/5013#discussion_r1776276454
##########
catalogs/catalog-jdbc-oceanbase/src/main/java/org/apache/gravitino/catalog/oceanbase/operation/OceanBaseDatabaseOperations.java:
##########
@@ -45,17 +55,62 @@ private static Set<String>
createSysOceanBaseDatabaseNames() {
public String generateCreateDatabaseSql(
String databaseName, String comment, Map<String, String> properties) {
- throw new UnsupportedOperationException("Not implemented yet.");
+ String originComment = StringIdentifier.removeIdFromComment(comment);
Review Comment:
I think you can add such method:
```java
protected abstract boolean supportSchemaComment();
```
then handle the comment before call method `generateCreateDatabaseSql()`,
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
