jerryshao commented on code in PR #4894:
URL: https://github.com/apache/gravitino/pull/4894#discussion_r1775314670
##########
core/src/main/java/org/apache/gravitino/authorization/RoleManager.java:
##########
@@ -129,6 +133,26 @@ boolean deleteRole(String metalake, String role) {
}
}
+ String[] listRoleNames(String metalake) {
+ return
Arrays.stream(listRolesInternal(metalake)).map(Role::name).toArray(String[]::new);
+ }
+
+ private Role[] listRolesInternal(String metalake) {
+ try {
+ AuthorizationUtils.checkMetalakeExists(metalake);
+ Namespace namespace = AuthorizationUtils.ofRoleNamespace(metalake);
+ return store.list(namespace, RoleEntity.class, Entity.EntityType.ROLE,
false).stream()
Review Comment:
What I mean that for `role`, you don't even support this `allFields` field,
so it is meaningless to set `false` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
