jerqi commented on code in PR #4894:
URL: https://github.com/apache/gravitino/pull/4894#discussion_r1775211378


##########
common/src/main/java/org/apache/gravitino/dto/authorization/RoleDTO.java:
##########
@@ -186,9 +192,6 @@ public S withAudit(AuditDTO audit) {
     public RoleDTO build() {
       Preconditions.checkArgument(StringUtils.isNotBlank(name), "name cannot 
be null or empty");
       Preconditions.checkArgument(audit != null, "audit cannot be null");
-      Preconditions.checkArgument(
-          securableObjects != null && securableObjects.length != 0,
-          "securable objects can't null or empty");

Review Comment:
   Yes, if one role has one securable object about catalog, and we remove the 
catalog. the securable objects could be empty.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to