mchades commented on code in PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#discussion_r1772506639


##########
integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/RangerContainer.java:
##########
@@ -38,7 +38,7 @@ public class RangerContainer extends BaseContainer {
   public static final String DEFAULT_IMAGE = 
System.getenv("GRAVITINO_CI_RANGER_DOCKER_IMAGE");
   public static final String HOST_NAME = "gravitino-ci-ranger";
   public static final int RANGER_SERVER_PORT = 6080;
-  public RangerClientExtension rangerClient;
+  public RangerClient rangerClient;

Review Comment:
   I saw that this variable was originally used `RangerClient`, then you 
changed it to `RangerClientExtension`, why did you change it back to 
`RangerClient`? Did I miss something?



##########
gradle/libs.versions.toml:
##########
@@ -217,7 +218,7 @@ datanucleus-core = { group = "org.datanucleus", name = 
"datanucleus-core", versi
 datanucleus-api-jdo = { group = "org.datanucleus", name = 
"datanucleus-api-jdo", version.ref = "datanucleus-api-jdo" }
 datanucleus-rdbms = { group = "org.datanucleus", name = "datanucleus-rdbms", 
version.ref = "datanucleus-rdbms" }
 datanucleus-jdo = { group = "org.datanucleus", name = "javax.jdo", version.ref 
= "datanucleus-jdo" }
-
+apiguardian-api = { group = "org.apiguardian", name = "apiguardian-api", 
version.ref = "apiguardian-api" }

Review Comment:
   Need to add to `LICENSE.bin`?



##########
integration-test-common/build.gradle.kts:
##########
@@ -54,25 +61,41 @@ dependencies {
     exclude("org.elasticsearch")
     exclude("org.elasticsearch.client")
     exclude("org.elasticsearch.plugin")
+    exclude("com.amazonaws", "aws-java-sdk-bundle")
   }
+  testImplementation(libs.apiguardian.api)
+  testImplementation(libs.bundles.metrics)
+  testImplementation(libs.junit.jupiter.params)
+  testImplementation(libs.junit.jupiter.api)
+  testImplementation(libs.junit.jupiter.engine)
+  testImplementation(libs.bundles.jersey)

Review Comment:
   not done



##########
server-common/src/main/java/org/apache/gravitino/server/web/JettyServer.java:
##########
@@ -260,6 +260,29 @@ private void initializeWebAppServletContextHandler() {
     servletContextHandler = new WebAppContext();
 
     boolean isUnitTest = System.getenv("GRAVITINO_TEST") != null;
+    if (isUnitTest) {

Review Comment:
   @xunliu need answer.



##########
integration-test-common/build.gradle.kts:
##########
@@ -54,25 +62,39 @@ dependencies {
     exclude("org.elasticsearch")
     exclude("org.elasticsearch.client")
     exclude("org.elasticsearch.plugin")
+    exclude("com.amazonaws", "aws-java-sdk-bundle")
   }
+  testImplementation(libs.junit.jupiter.params)
+  testImplementation(libs.junit.jupiter.api)
+  testImplementation(libs.junit.jupiter.engine)
+  testImplementation(libs.bundles.jersey)
+}
 
-  testImplementation(platform("org.junit:junit-bom:5.9.1"))
-  testImplementation("org.junit.jupiter:junit-jupiter")
+val testShadowJar by tasks.registering(ShadowJar::class) {

Review Comment:
   Yeah, just like mini HMS. It can be imported and setup directly by other 
programs without introducing additional dependencies.
   



##########
core/src/main/java/org/apache/gravitino/storage/relational/database/H2Database.java:
##########
@@ -54,6 +54,12 @@ public String startH2Database(Config config) {
 
     String connectionUrl = constructH2URI(originalJDBCUrl, storagePath);
 
+    try {
+      Class.forName("org.h2.Driver");

Review Comment:
   I am confused about why it worked before without needing an explicit call?



##########
server-common/src/main/java/org/apache/gravitino/server/web/JettyServer.java:
##########
@@ -260,6 +260,29 @@ private void initializeWebAppServletContextHandler() {
     servletContextHandler = new WebAppContext();
 
     boolean isUnitTest = System.getenv("GRAVITINO_TEST") != null;
+    if (isUnitTest) {

Review Comment:
   Why does only UT need this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to