mchades commented on code in PR #4343:
URL: https://github.com/apache/gravitino/pull/4343#discussion_r1705080454
##########
docs/jdbc-doris-catalog.md:
##########
@@ -41,16 +41,16 @@ more details.
Besides the [common catalog
properties](./gravitino-server-config.md#gravitino-catalog-properties-configuration),
the Doris catalog has the following properties:
-| Configuration item | Description
| Default value
| Required | Since Version |
-|---------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------------------------------------------|----------|---------------|
-| `jdbc-url` | JDBC URL for connecting to the database. For
example, `jdbc:mysql://localhost:9030`
| (none)
| Yes | 0.5.0 |
-| `jdbc-driver` | The driver of the JDBC connection. For example,
`com.mysql.jdbc.Driver`.
| (none)
| Yes | 0.5.0 |
-| `jdbc-user` | The JDBC user name.
| (none)
| Yes | 0.5.0 |
-| `jdbc-password` | The JDBC password.
| (none)
| Yes | 0.5.0 |
-| `jdbc.pool.min-size` | The minimum number of connections in the pool.
`2` by default.
| `2`
| No | 0.5.0 |
-| `jdbc.pool.max-size` | The maximum number of connections in the pool.
`10` by default.
| `10`
| No | 0.5.0 |
-| `jdbc.pool.max-size` | The maximum number of connections in the pool.
`10` by default.
| `10`
| No | 0.5.0 |
-| `replication_allocation` | The number of replications for the table. If not
specified and the backend server less than 3, then Gravitino use will the
default value `tag.location.default: 1`. | `tag.location.default: 1` if backend
server less than 3 | No | 0.6.0 |
+| Configuration item | Description
| Default value | Required | Since Version |
+|----------------------|---------------------------------------------------------------------------------------------------------------------------------------|-----------------------------------|----------|---------------|
+| `jdbc-url` | JDBC URL for connecting to the database. For example,
`jdbc:mysql://localhost:9030`
| (none) | Yes | 0.5.0 |
+| `jdbc-driver` | The driver of the JDBC connection. For example,
`com.mysql.jdbc.Driver`.
| (none) | Yes | 0.5.0 |
+| `jdbc-user` | The JDBC user name.
| (none) | Yes | 0.5.0 |
+| `jdbc-password` | The JDBC password.
| (none) | Yes | 0.5.0 |
+| `jdbc.pool.min-size` | The minimum number of connections in the pool. `2` by
default.
| `2` | No | 0.5.0 |
+| `jdbc.pool.max-size` | The maximum number of connections in the pool. `10`
by default.
| `10` | No | 0.5.0 |
+| `jdbc.pool.max-size` | The maximum number of connections in the pool. `10`
by default.
| `10` | No | 0.5.0 |
+| `replication_num` | The number of replications for the table. If not
specified and the number of backend server less than 3, then the default value
is 1. | `1` if backend server less than 3 | No | 0.6.0 |
Review Comment:
I say what if not less than 3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
