mchades commented on code in PR #4343:
URL: https://github.com/apache/gravitino/pull/4343#discussion_r1705014504
##########
catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java:
##########
@@ -164,6 +168,37 @@ protected String generateCreateTableSql(
return result;
}
+ private Map<String, String> appendNecessaryProperties(Map<String, String>
properties) {
+ Map<String, String> resultMap;
+ if (properties == null) {
+ resultMap = new HashMap<>();
+ } else {
+ resultMap = new HashMap<>(properties);
+ }
+
+ // If the backend server is less than 3, we need to set the property
'replication_allocation'
+ // to 1 explicitly.
+ if (!properties.containsKey(REPLICATION_FACTOR)) {
Review Comment:
If the user sets the property value to more than 3 when the backend server
is less than 3, they should provide a response with the result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
