mchades commented on code in PR #3961:
URL: https://github.com/apache/gravitino/pull/3961#discussion_r1677372459


##########
catalogs/catalog-jdbc-doris/src/main/java/com/datastrato/gravitino/catalog/doris/operation/DorisTablePartitionOperations.java:
##########
@@ -0,0 +1,343 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package com.datastrato.gravitino.catalog.doris.operation;
+
+import static com.google.common.base.Preconditions.checkArgument;
+
+import com.datastrato.gravitino.catalog.doris.utils.DorisUtils;
+import com.datastrato.gravitino.catalog.jdbc.converter.JdbcExceptionConverter;
+import com.datastrato.gravitino.catalog.jdbc.converter.JdbcTypeConverter;
+import 
com.datastrato.gravitino.catalog.jdbc.operation.JdbcTablePartitionOperations;
+import com.datastrato.gravitino.exceptions.GravitinoRuntimeException;
+import com.datastrato.gravitino.exceptions.NoSuchPartitionException;
+import com.datastrato.gravitino.exceptions.PartitionAlreadyExistsException;
+import com.datastrato.gravitino.rel.expressions.literals.Literal;
+import com.datastrato.gravitino.rel.expressions.literals.Literals;
+import com.datastrato.gravitino.rel.expressions.transforms.Transform;
+import com.datastrato.gravitino.rel.expressions.transforms.Transforms;
+import com.datastrato.gravitino.rel.partitions.ListPartition;
+import com.datastrato.gravitino.rel.partitions.Partition;
+import com.datastrato.gravitino.rel.partitions.Partitions;
+import com.datastrato.gravitino.rel.partitions.RangePartition;
+import com.datastrato.gravitino.rel.types.Type;
+import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableMap;
+import java.sql.Connection;
+import java.sql.DatabaseMetaData;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.sql.Statement;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+import java.util.stream.Collectors;
+import javax.sql.DataSource;
+
+public final class DorisTablePartitionOperations extends 
JdbcTablePartitionOperations {
+  private static final String RANGE_PARTITION_PATTERN_STRING =
+      "types: \\[([^\\]]+)\\]; keys: \\[([^\\]]+)\\];";
+  private static final Pattern RANGE_PARTITION_PATTERN =
+      Pattern.compile(RANGE_PARTITION_PATTERN_STRING);
+
+  private final JdbcExceptionConverter exceptionConverter;
+  private final JdbcTypeConverter typeConverter;
+
+  public DorisTablePartitionOperations(
+      DataSource dataSource,
+      String databaseName,
+      String tableName,
+      JdbcExceptionConverter exceptionConverter,
+      JdbcTypeConverter typeConverter) {
+    super(dataSource, databaseName, tableName);
+    checkArgument(exceptionConverter != null, "exceptionConverter is null");
+    checkArgument(typeConverter != null, "typeConverter is null");
+    this.exceptionConverter = exceptionConverter;
+    this.typeConverter = typeConverter;
+  }
+
+  @Override
+  public String[] listPartitionNames() {
+    try (Connection connection = getConnection(databaseName)) {
+      getPartitionInfo(connection);

Review Comment:
   @xiaozcy please rebase the main branch and resolve the conflicts when you 
have time, thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to