xiaozcy commented on code in PR #3961: URL: https://github.com/apache/gravitino/pull/3961#discussion_r1663385378
########## api/src/main/java/com/datastrato/gravitino/exceptions/NotPartitionedTableException.java: ########## @@ -0,0 +1,35 @@ +/* + * Copyright 2024 Datastrato Pvt Ltd. + * This software is licensed under the Apache License version 2. + */ +package com.datastrato.gravitino.exceptions; + +import com.google.errorprone.annotations.FormatMethod; +import com.google.errorprone.annotations.FormatString; + +/** Exception thrown when a partitioned table does not exist. */ +public class NotPartitionedTableException extends GravitinoRuntimeException { Review Comment: > JDBCTableOperation is support Mysql and PG first which doesn't support partition(Gravitino MySQL catalog doesn't support). we could extend the interface if support partition for doris. Got that, maybe I could create an issue and fix it later. Back to this PR, should we introduce `NotPartitionedTableException` for non-partitioned table? What's your opinion? @yuqi1129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org