ayush00git commented on code in PR #3579:
URL: https://github.com/apache/fory/pull/3579#discussion_r3106899610
##########
rust/fory-core/src/fory.rs:
##########
@@ -599,12 +668,14 @@ impl Fory {
WRITE_CONTEXTS.with(|cache| {
let cache = unsafe { &mut *cache.get() };
let id = self.id;
- let config = self.config.clone();
let context = cache.get_or_insert_result(id, || {
// Only fetch type resolver when creating a new context
let type_resolver = self.get_final_type_resolver()?;
- Ok(Box::new(WriteContext::new(type_resolver.clone(), config)))
+ Ok(Box::new(WriteContext::new(
+ type_resolver.clone(),
+ self.config.clone(),
Review Comment:
previously it was cloned as well, i just moved it inside creation closure,
which avoided its access on every serialize call and using its cached context
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
