ayush00git commented on PR #3579: URL: https://github.com/apache/fory/pull/3579#issuecomment-4275548306
> Only stream mode do not introduce any performance regression, then we will support it in fory rust. @chaokunyang could you please share me the outputs of terminal or example of operations which are showing regressions? I tried a lot debugging, regressions are there in write path f32/f64 and sometimes in some other ops as well, and i'm thinking some of these are just because of noise. size guardrails should've introduced regressions in the read path, but they didn't, the most likely cause of regression in the write path is the buffer pre-reservation that i made in this [commit](https://github.com/apache/fory/pull/3579/commits/91c120de3c6737298c67e75d97da3f201b9907c1). I'm investigating further, please if you find a likely cause running the benches on your machine, do guide me through what was real regressions or just noise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
