yash-agarwa-l commented on issue #3558: URL: https://github.com/apache/fory/issues/3558#issuecomment-4241944350
Hi, I am sorry for the delay, Just a quick question before I open the PR;`benchmarks/dart/lib/src/workloads.dart` on main calls `Fory(config: const Config(compatible: true))` after the refactor(dart) PR, but PR #3560 refactored the Fory constructor which donot contain config parameter now, and it donot compile. I think i should fix this line to `Fory(compatible: true)` in my perf PR (matches what #3560 did to the test files). Is that fine, or shall i make a separate cleanup PR first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
