adamsaghy commented on code in PR #5565:
URL: https://github.com/apache/fineract/pull/5565#discussion_r2874561187
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChart.java:
##########
@@ -177,9 +177,6 @@ public void validateChartSlabs(DataValidatorBuilder
baseDataValidator) {
}
}
- } else if (iSlabs.slabFields().isNotProperPriodEnd()) {
Review Comment:
why is this removed? it was incorrect?
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChartSlabFields.java:
##########
@@ -247,11 +247,6 @@ public static boolean
isNotProperPeriodStart(InterestRateChartSlabFields interes
&& !(interestRateChartSlabFields.fromPeriod.equals(1) ||
interestRateChartSlabFields.fromPeriod.equals(0));
}
- public boolean isNotProperPriodEnd() {
Review Comment:
why is this removed? was it incorrect?
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChart.java:
##########
@@ -177,9 +177,6 @@ public void validateChartSlabs(DataValidatorBuilder
baseDataValidator) {
}
}
- } else if (iSlabs.slabFields().isNotProperPriodEnd()) {
Review Comment:
why is this removed? was it incorrect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
