airajena opened a new pull request, #5565: URL: https://github.com/apache/fineract/pull/5565
## Summary This PR fixes a validation bug where updating/creating term deposit products with valid chart slabs could fail with: `validation.msg.recurringdeposit.chart.slabs.range.end.incorrect` The issue appeared for well-formed terminal slabs (for example: `fromPeriod=0`, `toPeriod=3`). ## Root Cause Chart slab validation in `InterestRateChart.validateChartSlabs(...)` treated certain end-range values as invalid even when there was no subsequent slab requiring continuity validation. ## Changes - Removed incorrect end-range validation branches - Removed obsolete helper method no longer used by validation ## Scope - No API contract changes - No schema/Liquibase changes - No behavior changes outside chart slab validation in term deposit interest chart domain ## Validation Executed locally: - `./gradlew :fineract-savings:test --tests org.apache.fineract.portfolio.interestratechart.domain.InterestRateChartValidationTest` - `./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest` ## Risk Low. Changes are localized to chart validation logic + one focused regression test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
