vidakovic commented on code in PR #5562:
URL: https://github.com/apache/fineract/pull/5562#discussion_r2869675430
##########
fineract-core/src/main/java/org/apache/fineract/organisation/staff/domain/Staff.java:
##########
@@ -112,6 +113,67 @@ public static Staff fromJson(final Office staffOffice,
final JsonCommand command
return new Staff(staffOffice, firstname, lastname, externalId,
mobileNo, isLoanOfficer, isActive, joiningDate);
}
+ public static Staff fromRequest(final Office staffOffice, final
StaffRequest request) {
Review Comment:
All good @nidhiii128 your approach makes sense to get this PR approved;
introducing new libs/dependencies "on the fly" without at least a Jira ticket
usually doesn't get a PR approved. Will start the build so that we can see
where we are with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
