nidhiii128 commented on PR #5562: URL: https://github.com/apache/fineract/pull/5562#issuecomment-3979549917
> @nidhiii128 please work on this jira ticket, I am unable to assign this to you, but please pick it: https://issues.apache.org/jira/browse/FINERACT-2515 Hi @iohacker, I saw the updates to the ticket. I actually started working on the refactor the moment you posted the task, focusing on the 'bad practice' note regarding the PortfolioAccountType methods. I have just submitted a Pull Request that addresses exactly what was discussed: I've removed the redundant isSavingsAccount() and isLoanAccount() methods from the Enum and updated all callers across the provider and core modules to use direct enum comparisons. The build is passing locally after a fresh rebase against develop. Looking forward to your feedback! PR Link: https://github.com/apache/fineract/pull/5563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
