adamsaghy commented on code in PR #4977:
URL: https://github.com/apache/fineract/pull/4977#discussion_r2309592889
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/ProgressiveLoanTransactionValidatorImpl.java:
##########
@@ -313,6 +321,11 @@ public void validateBuyDownFee(JsonCommand command, Long
loanId) {
final BigDecimal transactionAmount =
this.fromApiJsonHelper.extractBigDecimalWithLocaleNamed("transactionAmount",
element);
baseDataValidator.reset().parameter("transactionAmount").value(transactionAmount).notNull().positiveAmount();
+ final Long transactionClassificationId =
fromApiJsonHelper.extractLongNamed(LoanApiConstants.TRANSACTION_CLASSIFICATIONID_PARAMNAME,
+ element);
+
progressiveLoanTransactionService.validateClassificationCodeValue(LoanApiConstants.BUY_DOWN_FEE_CLASSIFICATION_CODE,
Review Comment:
same as above, we dont need an additional service
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/ProgressiveLoanTransactionValidatorImpl.java:
##########
@@ -577,8 +590,8 @@ public void validateManualInterestRefundTransaction(final
String json) {
}
private Set<String> getCapitalizedIncomeParameters() {
- return new HashSet<>(
- Arrays.asList("transactionDate", "dateFormat", "locale",
"transactionAmount", "paymentTypeId", "note", "externalId"));
+ return new HashSet<>(Arrays.asList("transactionDate", "dateFormat",
"locale", "transactionAmount", "paymentTypeId", "note",
+ "externalId",
LoanApiConstants.TRANSACTION_CLASSIFICATIONID_PARAMNAME));
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
