adamsaghy commented on code in PR #4977:
URL: https://github.com/apache/fineract/pull/4977#discussion_r2309589663
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/ProgressiveLoanTransactionValidatorImpl.java:
##########
@@ -276,7 +283,8 @@ public void validateContractTerminationUndo(final
JsonCommand command, final Lon
}
private static final List<String>
BUY_DOWN_FEE_TRANSACTION_SUPPORTED_PARAMETERS = List
- .of(new String[] { "transactionDate", "dateFormat", "locale",
"transactionAmount", "paymentTypeId", "note", "externalId" });
+ .of(new String[] { "transactionDate", "dateFormat", "locale",
"transactionAmount", "paymentTypeId", "note", "externalId",
+ LoanApiConstants.TRANSACTION_CLASSIFICATIONID_PARAMNAME });
Review Comment:
Be consistent, use the string literal here please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
