nkuprins opened a new pull request, #1001:
URL: https://github.com/apache/fesod/pull/1001
Related: #1000
## Purpose of the pull request
`EscapeHexCellWriteHandler` has no tests. It used to have them, but they
were deleted by accident (read #1000).
_This PR is not a blind restore of those lost tests! I took a different
approach; for example, `@ParameterizedTest` were used for better scalability
and readability, etc._
## What's changed?
- **Two parameterised tables** covering the escaping rule itself. Seven
inputs that must be rewritten (`_xHHHH_` to `_x005F_xHHHH_`) and eight that
must be left exactly as typed.
- **Non-idempotency**: an already-escaped literal is escaped *again*.
- **Guard tests** for the inputs the handler must not act on: non-`STRING`
cell data, a null `WriteCellData`, and a `STRING` holding a null value.
- **One end-to-end case**, parameterised over XLSX/XLS/CSV with
`@ExcelFormatSource`: write a file through Fesod with the handler registered,
read it back, and require the caller's literal. It sits in its own class tagged
`ROUND_TRIP`, which keeps the rest tagged `UNIT`.
## Checklist
- [x] I have read the [Contributor
Guide](https://fesod.apache.org/community/contribution/).
- [x] I have written the necessary doc or comment.
- [x] I have added the necessary unit tests and all cases have passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
