nkuprins opened a new issue, #1000: URL: https://github.com/apache/fesod/issues/1000
### Search before asking - [x] I searched in the [issues](https://github.com/apache/fesod/issues) and found nothing similar. ### Motivation While working on #991, I noticed that `EscapeHexCellWriteHandler` has no dedicated tests, and the pattern-scanning code has some edges worth tidying. ### Solution I will do it in 2 PR. ### 1. Testing - [ ] Cover the escaping logic itself - valid patterns get rewritten, invalid/edge-case ones don't, and non-applicable inputs (wrong cell data type, null values) are safely ignored. - [ ] Cover it end-to-end - write a file through Fesod with the handler registered and confirm the escaped value survives being read back. ### 2. Refactoring/cleanup > Hold off reviewing this section until 1. is merged - the tests need to pin current behaviour before > anything underneath them moves. - [ ] Reduce duplication in the pattern-scanning code - the match-detection logic is currently written out twice across two methods. - [ ] Improve readability of the low-level string offsets (magic numbers, member ordering), so the logic is easier to verify by inspection. ### Alternatives _No response_ ### Anything else? _No response_ ### Are you willing to submit a PR? - [x] I'm willing to submit a PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
