FrankChen021 commented on code in PR #19541:
URL: https://github.com/apache/druid/pull/19541#discussion_r3420714084
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/LagAggregator.java:
##########
@@ -48,6 +49,18 @@ public interface LagAggregator
*/
class DefaultLagAggregator implements LagAggregator
{
+ private DefaultLagAggregator()
Review Comment:
[P2] Preserve the public default constructor
`DefaultLagAggregator` is a public nested class of a public interface, so
before this PR its implicit no-arg constructor was public. Making that
constructor private breaks source compatibility and can also break
already-compiled extensions or callers that instantiate `new
LagAggregator.DefaultLagAggregator()` after upgrade. The singleton
`@JsonCreator` can coexist with a public constructor, or the equality concern
can be handled without removing the constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
