kfaraz commented on code in PR #19541:
URL: https://github.com/apache/druid/pull/19541#discussion_r3401711602
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorManager.java:
##########
@@ -209,24 +328,18 @@ public boolean shouldUpdateSupervisor(SupervisorSpec spec)
Preconditions.checkNotNull(spec.getDataSources(), "spec.getDatasources()");
synchronized (lock) {
Preconditions.checkState(started, "SupervisorManager not started");
- try {
- byte[] specAsBytes = jsonMapper.writeValueAsBytes(spec);
- Pair<Supervisor, SupervisorSpec> currentSupervisor =
supervisors.get(spec.getId());
- if (currentSupervisor == null || currentSupervisor.rhs == null) {
- return true;
- } else if (Arrays.equals(specAsBytes,
jsonMapper.writeValueAsBytes(currentSupervisor.rhs))) {
- return false;
- } else {
- // The spec bytes are different, so we need to check if the update
is allowed
- currentSupervisor.rhs.validateSpecUpdateTo(spec);
- return true;
- }
+ final Pair<Supervisor, SupervisorSpec> currentSupervisor =
supervisors.get(spec.getId());
+ if (currentSupervisor == null || currentSupervisor.rhs == null) {
+ return true;
Review Comment:
Nit: We can probably skip this check since the invoked method
`isSpecChangedAndValidate` does it anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
