beenhead commented on PR #19547: URL: https://github.com/apache/druid/pull/19547#issuecomment-4679118044
Thanks @vogievetsky — addressed all of these in `e8db8e9f55`. The main change: instead of paralleling the existing converter, `convertSupervisorToSql` now rewrites the supervisor spec into an `index_parallel` spec and delegates to `convertSpecToSql`. That deletes ~400 lines and resolves the MetricSpec/util/IngestionSpec reuse comments at the root — and it inherits the existing converter's column-type, granularity, and timestamp handling (which also covers the earlier P1/P2 feedback). Remaining comments (Blueprint 5 scss + dropdown, index.ts, one-shot wording, inline snapshots) are all done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
