beenhead commented on code in PR #19547:
URL: https://github.com/apache/druid/pull/19547#discussion_r3389140578
##########
web-console/src/views/workbench-view/workbench-view.tsx:
##########
@@ -496,6 +507,21 @@ export class WorkbenchView extends
React.PureComponent<WorkbenchViewProps, Workb
);
}
+ private renderSupervisorToSqlDialog() {
+ const { supervisorToSqlDialogOpen } = this.state;
+ if (!supervisorToSqlDialogOpen) return;
+
+ return (
+ <SupervisorToSqlDialog
+ onConvert={(sql: string) => {
+ this.handleQueryStringChange(sql);
Review Comment:
Fixed to match the ingestion-spec flow. Conversion now opens a new workbench
tab via handleNewTab(WorkbenchQuery.blank()…) titled `Convert <datasource>`,
rather than calling `handleQueryStringChange` on the current tab. Using a blank
query also means the engine/context are derived fresh for the `INSERT/EXTERN`
instead of inheriting the active tab's, so an unsaved query is no longer
replaced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
