gianm commented on PR #19063: URL: https://github.com/apache/druid/pull/19063#issuecomment-4357860368
> processing/src/main/java/org/apache/druid/segment/projections/Projections.java:332 - [P2] Preserve elseValue when remapping filtered projection aggregators. This projection rewrite unwraps a FilteredAggregatorFactory, remaps its filter, then recreates it with the two-argument constructor, which drops the new elseValue. A $SUM_FILTER_ELSE query that is satisfied from an aggregate projection can therefore lose the PR's zero-on-nonempty-no-match behavior and return NULL again. Recreate the filtered factory with filteredQueryAgg.getElseValue() (and the correct name if needed) when building remappedFilteredAgg. Fair enough, fixed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
