FrankChen021 commented on PR #19063: URL: https://github.com/apache/druid/pull/19063#issuecomment-4327407486
Findings that could not be attached inline: - processing/src/main/java/org/apache/druid/query/aggregation/FilteredAggregatorFactory.java:287 - [P1] Avoid empty IntervalDimFilter for elseValue no-match segments. When an interval filter has no overlap with the segment and elseValue is non-null, this no longer returns SuppressedAggregatorFactory and falls through to construct a new IntervalDimFilter with effectiveFilterIntervals empty. IntervalDimFilter rejects empty interval lists, so queries planned as $SUM_FILTER_ELSE over a time predicate outside a segment can fail during per-segment optimization instead of returning the intended else/null result. Handle the all-excluded case with a false filter or another aggregator that can emit elseValue without creating an empty IntervalDimFilter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
