clintropolis commented on PR #19375: URL: https://github.com/apache/druid/pull/19375#issuecomment-4325332547
>Seems ok to me although I'm wondering about Frank's comment. Its like kind of real, but also maybe unlikely to ever happen in practice given standard uses of nested writers. The usage is like a column serializer is open and writing and needs to open a nested writer to write some of its parts to separate files which needs some temp files to do that get merged back in later. The problem described would occur only i think if someone closed the outer thingy but not the nested, then set a new group, then close the nested ones (which i'm not entirely sure how would occur with our current index merger paths). Nothing does this, because its pretty strange? I went ahead and fixed the problem. Well, with the same limitations as the builder currently has here, that if the files aren't added to a group contiguously then they get stored in different containers, but it does at least ensure that containers have at most 1 group. So, if someone manages to do ^, it will put them into separate container associated with the group at the time of delegation instead of the current active group. 🤷 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
