FrankChen021 commented on PR #19375: URL: https://github.com/apache/druid/pull/19375#issuecomment-4318368571
Findings that could not be attached inline: - processing/src/main/java/org/apache/druid/segment/file/SegmentFileBuilderV10.java:718 - P1 Delegated nested writes lose their file group. Nested addWithChannel calls are delegated while writerCurrentlyInUse is true, but mergeDelegatedFiles later replays those files with add(name, file) using whatever currentFileGroup is active at merge time. The original group active when the nested write was requested is not retained. If a nested file is created under one projection/container group and merged after the outer writer advances or clears the group, that nested file can be appended to the wrong container group, breaking the projection-to-container layout that partial loading depends on. Store the file group with each delegated temp file and restore/use it when merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
