jtuglu1 commented on code in PR #19269: URL: https://github.com/apache/druid/pull/19269#discussion_r3065576469
########## indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScaler.java: ########## Review Comment: I think we should try and move this min/max hit emission logic out of a specific auto-scaler implementation, and into the generic DynamicScaleActionNotice logic. All an auto-scaler implementation should do is tell what task count it recommends for a given supervisor. The supervisor has min/max task count configs, and should IMO attempt to apply the auto-scaler recommendation. This way, we don't need to keep worrying about maintaining observability parity between the auto-scaler implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
