Fly-Style commented on code in PR #19269:
URL: https://github.com/apache/druid/pull/19269#discussion_r3062313828
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScaler.java:
##########
@@ -239,19 +239,30 @@ private int computeDesiredTaskCount(List<Long> lags)
withinProportion, spec.getId()
);
- int currentActiveTaskCount = supervisor.getActiveTaskGroupsCount();
+ int currentActiveTaskCount = supervisor.getIoConfig().getTaskCount();
Review Comment:
I am still sure that is the correct approach - autoscaler explicitly changes
`taskCount` and operates with different task counts configurations.
Anyway, my aim of changing this was not only the change itself, but also to
born discussion.
@jtuglu1 WDYT regarding changing that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
