gianm commented on code in PR #19248:
URL: https://github.com/apache/druid/pull/19248#discussion_r3023329640
##########
pom.xml:
##########
@@ -96,21 +96,21 @@
<datasketches.memory.version>2.2.0</datasketches.memory.version>
<derby.version>10.14.2.0</derby.version>
<dropwizard.metrics.version>4.2.22</dropwizard.metrics.version>
- <errorprone.version>2.35.1</errorprone.version>
+ <errorprone.version>2.41.0</errorprone.version>
<fabric8.version>7.6.0</fabric8.version>
<fastutil.version>8.5.4</fastutil.version>
<guava.version>32.1.3-jre</guava.version>
<guice.version>6.0.0</guice.version>
<hamcrest.version>2.2</hamcrest.version>
<jetty.version>12.0.30</jetty.version>
<jersey.version>1.19.4</jersey.version>
- <jackson.version>2.19.2</jackson.version>
+ <jackson.version>2.20.1</jackson.version>
Review Comment:
Why not 2.20.2?
##########
pom.xml:
##########
@@ -1083,7 +1108,17 @@
<dependency>
<groupId>org.roaringbitmap</groupId>
<artifactId>RoaringBitmap</artifactId>
- <version>0.9.49</version>
+ <version>1.3.0</version>
Review Comment:
What changed between these versions? 0.9.49 -> 1.3.0 seems major, so we
should understand the changes. The most important thing is to ensure there
aren't compatibility concerns, like a change in the serialization format.
Also, why 1.3.0? The latest is 1.6.13.
##########
pom.xml:
##########
@@ -484,6 +484,21 @@
<artifactId>logging-interceptor</artifactId>
<version>${okhttp.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.squareup.okio</groupId>
+ <artifactId>okio</artifactId>
+ <version>3.16.4</version>
+ </dependency>
+ <dependency>
+ <groupId>redis.clients</groupId>
+ <artifactId>jedis</artifactId>
+ <version>7.0.0</version>
Review Comment:
It's a major upgrade, anything to worry about? Do we have tests that would
catch problems?
##########
pom.xml:
##########
@@ -96,21 +96,21 @@
<datasketches.memory.version>2.2.0</datasketches.memory.version>
<derby.version>10.14.2.0</derby.version>
<dropwizard.metrics.version>4.2.22</dropwizard.metrics.version>
- <errorprone.version>2.35.1</errorprone.version>
+ <errorprone.version>2.41.0</errorprone.version>
<fabric8.version>7.6.0</fabric8.version>
<fastutil.version>8.5.4</fastutil.version>
<guava.version>32.1.3-jre</guava.version>
<guice.version>6.0.0</guice.version>
<hamcrest.version>2.2</hamcrest.version>
<jetty.version>12.0.30</jetty.version>
<jersey.version>1.19.4</jersey.version>
- <jackson.version>2.19.2</jackson.version>
+ <jackson.version>2.20.1</jackson.version>
<codehaus.jackson.version>1.9.13</codehaus.jackson.version>
<log4j.version>2.25.3</log4j.version>
<mysql.version>8.2.0</mysql.version>
<mariadb.version>2.7.3</mariadb.version>
<netty3.version>3.10.6.Final</netty3.version>
- <netty4.version>4.2.6.Final</netty4.version>
+ <netty4.version>4.2.7.Final</netty4.version>
Review Comment:
Why not 4.2.12?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
